Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PDLPorters/pdl
base: 05aca50d384c^
Choose a base ref
...
head repository: PDLPorters/pdl
compare: 358d0a79a24c
Choose a head ref
  • 7 commits
  • 10 files changed
  • 1 contributor

Commits on Mar 21, 2015

  1. Remove -Wunsequenced clang warnings. 

    All of these came from one line in Basic/Gen/PP.pm that used an
assignment in a macro argument. But in the Perl macro cascade
there is #defined HvAUX(hv), which uses its argument twice.
This caused the assignment to happen twice. It was a harmless
unintended consequence, but at least the warnings have gone away.
    @d-lamb @zmughal
    d-lamb authored and zmughal committed Mar 21, 2015
    Copy the full SHA
    05aca50 View commit details
    Browse the repository at this point in the history

  2. Remove clang -Wformat-security warnings. 

    It used to be that you could call printf(buf), but now for security
purposes it needs to be printf("%s",buf). Since Perl_croak just uses
printf (I think), I just added "%s" to a single line in Dev.pm.
    @d-lamb @zmughal
    d-lamb authored and zmughal committed Mar 21, 2015
    Copy the full SHA
    ce8016e View commit details
    Browse the repository at this point in the history

  3. Remove clang warning -Wlogical-op-parentheses for slices.pd 

    This is a bit nanny-ish, just asking for an extra set of parenthesis
to make sure we understand the C operator precedence rules. We do.
    @d-lamb @zmughal
    d-lamb authored and zmughal committed Mar 21, 2015
    Copy the full SHA
    2adac14 View commit details
    Browse the repository at this point in the history

  4. Remove clang -Wcomment warning about '/*' in a multi-line comment.

    @d-lamb @zmughal
    d-lamb authored and zmughal committed Mar 21, 2015
    Copy the full SHA
    124797b View commit details
    Browse the repository at this point in the history

  5. Remove clang -Wparentheses warning. 

    This warning happens when you do an assignment in a conditional:
if (a=something()).  Compiler checks to make sure you didn't mean
if (a==something()). Get around that by adding an extra set of
parentheses around the assignment.
    @d-lamb @zmughal
    d-lamb authored and zmughal committed Mar 21, 2015
    Copy the full SHA
    3ff7ac4 View commit details
    Browse the repository at this point in the history

  6. Suppress -Wliteral-conversion warning on clang for ufunc.pd. 

    clang was complaining because the generated code turned out to
be somthing like 'PDL_short foo = 0.25;' which is a type mismatch.
0.25 got rounded to 0 before assignment to PDL_short foo.
This is actually what the cheesy test for floating-pointiness
intended, so I suppressed that warning in the Makefile.PL.

An alternative would be to have a type() look for integers and
one for floating-point datatypes.
    @d-lamb @zmughal
    d-lamb authored and zmughal committed Mar 21, 2015
    Copy the full SHA
    b2a7008 View commit details
    Browse the repository at this point in the history

  7. Remove some -Wimplicit-int and -Wreturn-type clang warnings. 

    It's been a few decades since void was introduced...
    @d-lamb @zmughal
    d-lamb authored and zmughal committed Mar 21, 2015
    Copy the full SHA
    358d0a7 View commit details
    Browse the repository at this point in the history