Don't throw error when using db_fetch_array on empty resultset

When you execute a query which returns no results, an error is thrown when using db_fetch_array() on it, because the method tries to access the EOF property of an object which in that case is null. By adding an extra check on the passed p_result to see whether it is null, you can safely use db_fetch_array for instance in while loops, without having to always manually check whether or not the result has rows. This makes code more readable and faster. Fixes #14336 Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
mantisbt · Jun 1, 2012 · 33170d2 · 33170d2
1 parent c8a0c59
commit 33170d2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/core/database_api.php b/core/database_api.php
@@ -427,7 +427,7 @@ function db_affected_rows() {
 function db_fetch_array( &$p_result ) {
 	global $g_db, $g_db_type;
 
-	if( $p_result->EOF ) {
+	if( is_null( $p_result ) || $p_result->EOF ) {
 		return false;
 	}