[Truffle] Updates to Array#{map, map!}. #2714
Conversation
| toEnumNode = insert(DispatchHeadNodeFactory.createMethodCall(getContext())); | ||
| } | ||
|
|
||
| return toEnumNode.call(frame, array, "to_enum", null, getContext().getCoreLibrary().getMapBangSymbol()); |
There was a problem hiding this comment.
This is a very common pattern - maybe we should have an annotation on @CoreMethod called toEnumIfNoBlock?
There was a problem hiding this comment.
I see 90 occurrences of returns an Enumerator in the spec/ruby directory so I agree it would probably make a good annotation. I think this should be a different PR though.
There was a problem hiding this comment.
Yeah - do you want to take that on? If you look at the accessors of the other properties in @CoreMethod you should be able to find the code where they are inserted into the core method prelude.
There was a problem hiding this comment.
@chrisseaton yes, ill give it a try
|
We've got spec failures here but they look unrelated to your work. I'll try and fix them and then re-run the specs here later. |
bjfish
force-pushed
the
truffle_array_map_collect
branch
from
5cc7cad
to
f00f739
Compare
|
@chrisseaton extra lines removed |
[Truffle] Updates to Array#{map, map!}.
No description provided.