implements strict base64 encoding #2715
Merged
+105
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apparently the respective tests were excluded. Sponsored by Lookout Inc.
mkristian
force-pushed
the
strict-base64-encoding
branch
from
9a88ecf to
13ff7bf
Compare
|
👍 Looks good. |
mkristian
added a commit
that referenced
this pull request
Mar 19, 2015
implements strict base64 encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently the respective tests were excluded.
@headius could have a look - there is a lot of "duplication" but did not know how to avoid it. if this patch is OK I will also merge it to master.