Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for moving and copying nodes via the java and REST APIs #123

Closed
wants to merge 3 commits into from
Closed

Add support for moving and copying nodes via the java and REST APIs #123

wants to merge 3 commits into from

Conversation

cbeer
Copy link
Contributor

@cbeer cbeer commented Oct 23, 2013

awoods
awoods reviewed Oct 24, 2013
View reviewed changes
fcrepo-http-api/src/main/java/org/fcrepo/http/api/FedoraNodes.java

try {

final HttpGraphSubjects subjects =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to define "subjects" by its interface?
i.e. final GraphSubjects subjects = ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just what's used elsewhere in the file. Your call.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer using the interface... or else, what is the point?

@cbeer
Copy link
Contributor Author

cbeer commented Oct 24, 2013

addressed @awoods comments, ready to go.

@cbeer
Copy link
Contributor Author

cbeer commented Oct 24, 2013

Merged in a561e1f

@cbeer cbeer closed this Oct 24, 2013
@cbeer cbeer deleted the move-copy-57813074 branch October 24, 2013 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cbeer @awoods