Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make real Alien::Proj4 to break PDL::Transform::Proj4 -> PDL::GIS::Proj build dep #87

Closed
wants to merge 0 commits into from

Conversation

mohawk2
Copy link
Member

@mohawk2 mohawk2 commented Mar 21, 2015

Intended to address #81 so PDL will build Ok. Underlying silent-stopping issue remains, however.

return 1;
}

# dup of code currently in PDL::GIS::Proj
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a TODO to remove the dupes later?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that now.

@zmughal
Copy link
Member

zmughal commented Mar 21, 2015

Other than a little better documentation of TODOs, this seems fine. Why is projects.h not being found? It should be in /usr/include.

@mohawk2
Copy link
Member Author

mohawk2 commented Mar 21, 2015

Because of defective packaging.

@zmughal
Copy link
Member

zmughal commented Mar 21, 2015

Should be good when it passes in Travis-CI! :-) 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.95% when pulling 9db9245 on proj4fix into 8467166 on master.

@zmughal
Copy link
Member

zmughal commented Mar 22, 2015

This has been merged in 0745da9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants