Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support of const_get with leading colons #2739

Closed
wants to merge 1 commit into from
Closed

Fix support of const_get with leading colons #2739

wants to merge 1 commit into from

Conversation

arlandism
Copy link
Contributor

RE: #2635

Run via bin/jruby bin/jirb

2.1.1 :002 > module Bar
2.1.1 :003?>   module Foo
2.1.1 :004?>     class B
2.1.1 :005?>       A = "hey"
2.1.1 :006?>       end
2.1.1 :007?>     end
2.1.1 :008?>   end
 => "hey"
2.1.1 :010 > Object.const_get("::Bar::Foo::B::A")
 => "hey"

@arlandism
Copy link
Contributor Author

Any advice on adding a regression test around this? I referenced 5868779 to figure out some of the context around this code and didn't see a test there.

@kares
Copy link
Member

kares commented Mar 26, 2015

there's regression specs or you could add it as a (JRuby) test-case ... e.g. there's a test_module.rb already could use some tweaks to look like a "plain-old-test-case"

@kares kares added this to the 9.0.0.0.pre2 milestone Mar 26, 2015
@arlandism
Copy link
Contributor Author

@kares Thanks for the tips. I've added a couple of tests that expose the behavior and rebased them back into the first commit.

@kares
Copy link
Member

kares commented Apr 16, 2015

re-run travis-ci with a more recent (master) base and put the commit onto master with a slight tuning :) thx!

@kares kares closed this Apr 16, 2015
@arlandism
Copy link
Contributor Author

Thanks!

@kares kares mentioned this pull request Apr 16, 2015
Closed
@kares kares removed this from the 9.0.0.0.pre2 milestone Apr 16, 2015
@headius headius added this to the JRuby 9.0.0.0.pre2 milestone May 4, 2015
@headius
Copy link
Member

headius commented May 4, 2015

@kares I'm not clear whether this PR is considered merged or not, but all closed issues and PRs should have a milestone. There's a few catch-alls when something isn't in a release (Invalid/Duplicate, Won't Fix, Non-Release).

I'm marking this as pre2 based on the timing, but please update if that's not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
JRuby 9000 ruby 2.0-2.2
Projects
None yet
Milestone
JRuby 9.0.0.0.pre2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arlandism @kares @headius