Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Computers TE Memory Leak #968

Closed
lumien231 opened this issue Mar 21, 2015 · 12 comments
Closed

Open Computers TE Memory Leak #968

lumien231 opened this issue Mar 21, 2015 · 12 comments

Comments

@lumien231
Copy link

Using the latest 1.8 dev version of oc in my dev environment i noticed that my mods tile entitys are not being garbage collected when the chunk they are in is unloaded / i exit the world. Removing OC fixes this so i assume oc keeps a reference to them somewhere.

@fnuecke
Copy link
Member

fnuecke commented Mar 21, 2015

Which version of OC is this with? There were some leak related fixes very recently.

@lumien231
Copy link
Author

OpenComputers-MC1.8-1.5.3.53-dev-dev.jar The latest dev version.

@fnuecke
Copy link
Member

fnuecke commented Mar 21, 2015

OK, will try to reproduce.

@Kubuxu
Copy link
Contributor

Kubuxu commented Mar 21, 2015

@fnuecke it might be same problem as ours.

@fnuecke
Copy link
Member

fnuecke commented Mar 21, 2015

Hrm, didn't it only happen for Microcontrollers in your case, though?
@lumien231 any OC block in particular that seems to cause it?

@lumien231
Copy link
Author

I don't have to place any oc blocks for it to happen. The blocks it happens with also aren't components.

@Kubuxu
Copy link
Contributor

Kubuxu commented Mar 21, 2015

@fnuecke It was happening with everything connected to those uC.

@fnuecke
Copy link
Member

fnuecke commented Mar 21, 2015

Wait, so chunks fail to unload only by OC being present? That's... I have no idea what could cause that. Do the chunks fail to unload or are they immediately reloaded again? In the latter case, mind checking in validate() what keeps it loaded / reloads it?

@lumien231
Copy link
Author

So i didn't look into it THAT much to be honest, will see whether i can find out what exactly keeps it loaded. I just know that my tes aren't being garbage collected with oc installed.

@fnuecke
Copy link
Member

fnuecke commented Mar 21, 2015

Hrm, if the chunks actually are getting unloaded, maybe create a heap dump with VisualVM to figure out which GC root keeps them alive?

@lumien231
Copy link
Author

Okay now i can't reproduce this anymore :P, will reopen this if it happens again.

Sorry, something went wrong.

@fnuecke
Copy link
Member

fnuecke commented Mar 21, 2015

Allrighty.
inb4 vanilla bug :P

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants