Skip to content

Commit

Permalink
[Truffle] Tagged a failing Array#delete_if spec.
Browse files Browse the repository at this point in the history
  • Loading branch information
@nirvdrum
nirvdrum committed Mar 21, 2015
1 parent 23e9b95 commit ed2f7e0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions spec/truffle/tags/core/array/delete_if_tags.txt
View file
@@ -0,0 +1 @@
fails:Array#delete_if returns self when called on an Array emptied with #shift

8 comments on commit ed2f7e0

@nirvdrum
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjfish Specs seem to have been all messed up over the past 24 hours. I'm not sure why, but I think I fixed some String-related stuff. After that, I started seeing this Array#delete_if spec fail. I've retagged it for now. If you get a chance to look at it, that'd be helpful.

@bjfish
Copy link
Contributor

@bjfish bjfish commented on ed2f7e0 Mar 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirvdrum I was investigating this a little but haven't found the exact cause. I had trouble consistently reproducing the errors. I was suspicious of my reject! changes. I'll investigate more when I can.

@bjfish
Copy link
Contributor

@bjfish bjfish commented on ed2f7e0 Mar 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also saw green builds when specs were failing, is this the default behavior?

@nirvdrum
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link to the build? Travis sometimes flakes out.

@bjfish
Copy link
Contributor

@bjfish bjfish commented on ed2f7e0 Mar 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks green but has a spec failure in the middle https://travis-ci.org/jruby/jruby/jobs/55324179

@chrisseaton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's a failure inside MSpec, rather than inside a spec, so MSpec doesn't have a chance to set a nice error condition. We should probably exit(1) if an exception gets to the top level - we don't do that at the moment. I think @nirvdrum is working on the problem with chomp! anyway.

@nirvdrum
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chomp! issue should be fixed. If you see otherwise, please let me know.

@bjfish
Copy link
Contributor

@bjfish bjfish commented on ed2f7e0 Mar 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete_if should be fixed at 0bc4a57

Please sign in to comment.