Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.lock files left behind in PERL_INLINE_DIRECTORY #29

Closed
anthonybakermpls opened this issue Mar 17, 2015 · 4 comments
Closed

.lock files left behind in PERL_INLINE_DIRECTORY #29

anthonybakermpls opened this issue Mar 17, 2015 · 4 comments

Comments

@anthonybakermpls
Copy link

After a perl script builds inline CPP, a .lock file is left over in the PERL_INLINE_DIRECTORY under the username of the running user. This prevents subsequent runs by other users who share the PERL_INLINE_DIRECTORY and cannot delete the lock file left over. We are seeing this on Red hat linux with perl version 5.20.2 and inline:CPP version 0.71

@daoswald
Copy link
Owner

This is curious. The only ".lock" file created by the Inline::CPP distribution is created in Makefile.PL. It's unconditionally closed on line 222 of that file, and unlinked on line 225. But this wouldn't be doing anything in PERL_INLINE_DIRECTORY. PERL_INLINE_DIRECTORY is used at the time user code is built. The Makefile.PL lockfile is used only at the time that the Inline::CPP distribution is installed, and this would never be in the PERL_INLINE_DIRECTORY.

While there is some locking going on in Inline/CPP.pm, that file is a typemap, and doesn't have a ".lock" extension.

I believe the problem you are seeing is coming from Inline (most likely), or Inline::C, both of which Inline::CPP inherits from. I'm going to try to see if I can get confirmation of that suspicion from Inline/Inline::C maintainers before I close this though.

@mohawk2
Copy link
Collaborator

mohawk2 commented Mar 18, 2015

I implemented the locking in Inline, and I believe @daoswald is correct.

@anthonybakermpls
Copy link
Author

But does it make sense that this problem goes away when I remove the locking code for the typemap file in /lib/Inline/CPP.pm ?

@daoswald
Copy link
Owner

I suggest opening an issue in the Inline repo, since the .lock file is generated by Inline. If Inline determines that Inline::CPP is doing something wrong (which I don't think it is), then a new issue can be opened here with the background context of what we are doing wrong in our interaction with Inline. Meanwhile I'll close here; I don't see anything happening in Inline::CPP that should be to blame, and because messing with Inline's lock file from within Inline::CPP would be trashing someone else's closet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants