Skip to content

Back to sprockets ✨ #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Mar 23, 2015
Merged

Back to sprockets ✨ #43

merged 25 commits into from
Mar 23, 2015
+168 −109

Conversation

elia
Copy link
Member

@elia elia commented Mar 23, 2015

No description provided.

elia added 25 commits March 13, 2015 01:03
@elia
Point the Gemfile to opal@elia/source-maps-fix
d8576df
@elia
Only serve maps if Rails is compiling assets

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
11c4b8a
@elia
Use the new source map server
cf5f0bf 
That is supposed to be mounted on a different location than sprockets.
@elia
Bump opal-rspec min version
b106be8
@elia
Expect the map path to be absolute
bcc31c5
@elia
Ensure a spec fil can require opal without no harm
1ff59f5
@elia
Move opal_ujs to ruby
bcee522
@elia
Use Builder directly on opal spec controller
0fc5cee
@elia
Extract specialized spec builder
0e44a3f
@elia
Link to all specs should go on top
6894912
@elia
Add test_app opal:spec to the test task
1462834
@elia
Cleanup the spec_builder and split in smaller meth
7a10e17
@elia
Remove debug line
4d19411
@elia
No more extensions in the browser spec page
2f1c461
@elia
Update the opal:spec task to use the spec_builder
15d3517
@elia
Remove now unused files
78497e0
@elia
Remove obsolete helper
0961a02
@elia
Switch to elia/wip-back-to-sprockets opal branch
d0bf102
@elia
Overload javascript_include_tag with loading code
0251a8e
@elia
One route to spec them all
f2c4559
@elia
Split SpecBuilder#main_code into smaller methods
370b229
@elia
Add the loading code manually
8032763
@elia
Fix the assigns spec implementation
f0ecf5b
@elia
Keep spec dir up in paths priority
ddd2c94 
Other wise sprockets will use the first path it encounters as the logical_path,
which means that the file can potentially be registered in Opal.modules 
with the wrong path (e.g. if spec is in app/assets/javascripts/spec).
@elia
Update test_app env config to rails4
e258dc0
@elia elia mentioned this pull request Mar 23, 2015
Merged
elia added a commit that referenced this pull request Mar 23, 2015
@elia
Merge pull request #43 from opal/elia/wip-back-to-sprockets
836fc8c 
Back to sprockets ✨
@elia elia merged commit 836fc8c into master Mar 23, 2015
@elia elia deleted the elia/wip-back-to-sprockets branch March 23, 2015 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@elia