[Truffle] Adding frozen check to Array#delete. #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| isFrozenNode = insert(IsFrozenNodeFactory.create(getContext(), getSourceSection(), null)); | ||
| } | ||
| final boolean isFrozen = isFrozenNode.executeIsFrozen(array); | ||
|
|
There was a problem hiding this comment.
Can't this be hoisted to line 827?
|
Could this be another annotation? |
bjfish
force-pushed
the
truffle_array_delete_frozen
branch
from
db54205
to
af6bb3e
Compare
|
@chrisseaton I've hoisted that and refactored this a little. What did you have in mind for an annotation? I don't see this particular case occurring frequently. |
|
Ok, if I find myself copying and pasting this I'll think about it. |
chrisseaton
added a commit
that referenced
this pull request
Mar 19, 2015
[Truffle] Adding frozen check to Array#delete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.