Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usage of some deprecated classes. #26

Closed
wants to merge 6 commits into from

Conversation

KlasJoensson
Copy link
Contributor

This pull request replaces the following deprecated classes:
org.openscience.cdk.nonotify.NNAtomContainer
org.openscience.cdk.nonotify.NNChemFile
org.openscience.cdk.nonotify.NNMolecule
org.openscience.cdk.nonotify.NNMoleculeSet

It also replaces, where possibly, org.openscience.cdk.interfaces.IMolecule with org.openscience.cdk.interfaces.IAtomContainer

org.openscience.cdk.interfaces.IMolecule) {
imol = (org.openscience.cdk.interfaces.IMolecule)
cdkmol.getAtomContainer();
if (cdkmol.getAtomContainer() instanceof IAtomContainer) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. The check needs to check for IMolecule if it is going to cast it to IMolecule.
Keep the old code untill MoleculeSet is replace

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this is too dangerous for 'develop'.

@goglepox
Copy link
Contributor

I have merged the changes related to the use of NN... classes in to develop

The IMolecule -> IAtomcontainer change have to wait

@goglepox goglepox closed this May 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants