Code quality remained the same when pulling 3d23528 on thaytan:issue-100 into 901b3cb on timvideos:master.

Code quality remained the same when pulling 3362c65 on thaytan:issue-100 into 901b3cb on timvideos:master.

Why dvs?

Brainfart - I thought 'oh, call it after dvswitch -> dvs'. Something based on 'gst-switch' would be better, but I'm not sure what that is

It was suggested "gsw" for "gst-switch".

Code quality remained the same when pulling 05abe05 on thaytan:issue-100 into 901b3cb on timvideos:master.

I updated the patch. I'd be careful merging though - autovideoconvert doesn't seem to like the flexible negotiation gwsintervideosrc offers. I'd just use videoconvert instead of autovideoconvert though (and then it works) - autovideoconvert is silly.

Lets just do a complete s/autovideoconvert/videoconvert/ - Do you want me to do it or you?

Code quality remained the same when pulling f2d5b39 on thaytan:issue-100 into 901b3cb on timvideos:master.

Looks like GstVideoConverter isn't in trusty's gstreamer?

gstintervideosrc.c: In function 'gsw_inter_video_src_set_caps':
gstintervideosrc.c:217:3: error: unknown type name 'GstVideoConverter'
   GstVideoConverter *converter;
   ^
gstintervideosrc.c:241:3: error: implicit declaration of function 'gst_video_converter_new' [-Werror=implicit-function-declaration]
   converter = gst_video_converter_new (&black_info, &intervideosrc->info, NULL);
   ^
gstintervideosrc.c:241:13: error: assignment makes pointer from integer without a cast [-Werror]
   converter = gst_video_converter_new (&black_info, &intervideosrc->info, NULL);
             ^
gstintervideosrc.c:242:3: error: implicit declaration of function 'gst_video_converter_frame' [-Werror=implicit-function-declaration]
   gst_video_converter_frame (converter, &src_frame, &dest_frame);
   ^
gstintervideosrc.c:243:3: error: implicit declaration of function 'gst_video_converter_free' [-Werror=implicit-function-declaration]
   gst_video_converter_free (converter);
   ^
cc1: all warnings being treated as errors

ii  libgstreamer1.0-dev                                   1.2.4-0ubuntu1                                      amd64        GStreamer core development files

BTW I rebased and squashed your branch at https://github.com/mithro/gst-switch/tree/thaytan-issue-100

Oh. Missing GstVideoConverter is a problem :-/

What does GstVideoConverter do?

It's a more-recently-than-1.2 introduced helper class for transforming/generating video frames that lives in libgstvideo.

That is, it helps intervideosrc not have to know about how to generate blank frames in specific formats - the helper class does it.

@thaytan - so what our best option here?

@thaytan - Friendly poke! Would be really awesome to get this merged.

@thaytan Friendly poke :)

I'd really love to get this landed but not sure the best way to import the helper class that is needed.