Trunk 2303 #266
Closed
Trunk 2303 #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,8 @@ | |||
| package org.openmrs; | |||
|
|
|||
| import java.text.DateFormat; | |||
| import java.text.NumberFormat; // new formatter for getValueAsString | |||
There was a problem hiding this comment.
No need to comment import. Please remove it.
| @@ -31,8 +31,8 @@ | |||
| import org.openmrs.test.Verifies; | |||
|
|
|||
| /** | |||
| * This class tests all methods that are not getter or setters in the Obs java object TODO: finish | |||
| * this test class for Obs | |||
| * This class tests all methods that are not getter or setters in the Obs java | |||
There was a problem hiding this comment.
I don't think you have the right code template, and this line was reformatted to be too short. Make sure you have the code formatter and template defined at https://wiki.openmrs.org/display/docs/Coding+Conventions
|
Make sure to write more test cases, to reflect most of the scenarios described on the ticket. And please redo the formatting so that it doesn't introduce a bunch of spurious formatting changes. :-) |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.openmrs.org/browse/TRUNK-2303