Foreign key constraint violation on ConceptWord when removing a concept name - TRUNK-3690 #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,9 +54,9 @@ public void before_shouldNotifyListenersAboutCheckedPrivileges() { | |||
| Context.getConceptService().saveConcept(concept); | |||
|
|
|||
| Assert.assertArrayEquals("listener 1 save concept: " + listener1.hasPrivileges.toString(), new String[] { | |||
| "Manage Concepts", "Get Concepts", "Get Observations", "Get Concepts" }, listener1.hasPrivileges.toArray()); | |||
There was a problem hiding this comment.
These were duplicated because the validator was getting called twice which calls conceptService.getConceptByName each time to get duplicates, so removing the second invocation of it reduced it to 1 and changing the collectiion type from list to set
dkayiwa
added a commit
that referenced
this pull request
Apr 30, 2013
Foreign key constraint violation on ConceptWord when removing a concept name - TRUNK-3690
|
Right, but a LinkedHashSet is a special Set implementation that also maintains insertion order |
| new ConceptValidator().validate(concept, errors); | ||
| if (errors.hasErrors()) | ||
| throw new APIException("Validation errors found: " + errors.getAllErrors()); | ||
|
|
There was a problem hiding this comment.
Am not really getting rid of the validation, in the comment above i mentioned that there changes in core that were made where validators are invoked before saving an object, so it is already done at this point
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.openmrs.org/browse/TRUNK-3690