normalized configuration values #691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for cleaning this up. It does indeed seem more consistent to change |
test.port => fcrepo.test.port test.context.path => fcrepo.test.context.path RUN_TEST_CRUD_CONCURRENT => fcrepo.test.http.concurrent fcrepo4.tx.timeout => fcrepo.transactions.timeout fcrepo.test.dir1 => fcrepo.test.connector.file.directory1 fcrepo.test.dir2 => fcrepo.test.connector.file.directory2 fcrepo.test.properties.dir => fcrepo.test.connector.file.properties.directory The jgroups* configuration remain unchanged
|
Resolved with: 2e09b91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.duraspace.org/browse/FCREPO-1288
This PR does not add a central fcrepo.properties file (I wasn't able to get that to work consistently)
I am not wedded to any of the following changes, so if there are better naming conventions, please make suggestions.
The basic conventions I adopted were:
fcrepofcrepo.springfcrepo.ispncache(instead of CacheDirPath)directoryconfigurationThis renames the following configuration values:
fcrepo.activemq.dir=>fcrepo.activemq.directoryfcrepo.binary-store-path=>fcrepo.binary.directoryfcrepo.infinispan.cache_configuration=>fcrepo.ispn.configurationfcrepo.ispn.CacheDirPath=>fcrepo.ispn.cachefcrepo.ispn.alternative.CacheDirPath=>fcrepo.ispn.alternative.cachefcrepo.ispn.binary.CacheDirPath=>fcrepo.ispn.binary.cachefcrepo.ispn.binary.alternative.CacheDirPath=>fcrepo.ispn.binary.alternative.cachefcrepo.ispn.repo.CacheDirPath=>fcrepo.ispn.repo.cachefcrepo.minter.config=>fcrepo.spring.minter.configurationfcrepo.modeshape.index.location=>fcrepo.modeshape.index.directoryjms.host=>fcrepo.jms.hostjms.port=>fcrepo.jms.portstomp.port=>fcrepo.stomp.portThe following configuration values were added:
fcrepo.activemq.configurationfcrepo.spring.repo.configurationfcrepo.spring.rest.configurationfcrepo.spring.eventing.configurationfcrepo.spring.jms.configurationfcrepo.spring.transactions.configurationThe following values stayed the same:
fcrepo.homefcrepo.ispn.jgroups.configurationfcrepo.ispn.numOwnersfcrepo.ispn.replication.timeoutfcrepo.modeshape.configurationfcrepo.uuid.path.lengthfcrepo.uuid.path.countcom.arjuna.ats.arjuna.common.ObjectStoreEnvironmentBean.default.objectStoreDircom.arjuna.ats.arjuna.objectstore.objectStoreDirAlso, all of the
log.fcrepo.*values stayed the same, but I wonder whether they shouldn't befcrepo.log.*?