Checkstyle tests too 69355194 #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note... the second Travis failure is because the Checkstyle rules will need to be updated and an automated reformatting done for this PR to build. The first Travis failure was because I forgot to fix the version of the license-maven-plugin... that's been corrected with the third commit for this PR. |
|
Resolved with: 6bb1c05...8b51bd1 Addresses: https://www.pivotaltracker.com/story/show/69355194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Checkstyle configs so test classes would be checked too.
Added @author tag to tests that were missing it (using script at https://github.com/ksclarke/bash-scripts/blob/master/git-author.sh)
Updated license-maven-plugin to the newest version. My script uses a locally modified version of it. I plan to create PR to the upstream project with those changes.
This PR shouldn't be merged until the new version of the Checkstyle rules are implemented (fcrepo/fcrepo-build-tools#4) and the code base is ready to be made compatible with those changes (https://www.pivotaltracker.com/story/show/71267176). The tests will then be included with the work done for that pivotal ticket (which should just be an automated reformatting using Eclipse or some tool like it).