https://www.pivotaltracker.com/story/show/79728226 #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specific functionality that's causing the symptom noted in PT # 79728226 was introduced via commit fcrepo@068c346 Rationale for the PR: ReadOnlyExternalPropertiesFedoraFileSystemConnectorIT fails when trying to delete a file generated when running BasicReadWriteFedoraFileSystemConnectorIT. The former makes no use of this file, and hence shouldn't try to delete it (indirectly via AbstractFedoraFileSystemConnectorIT). This fixes the specific build error that result from attempting to delete a file that's still held on by another Java process. The file lock was observed on Windows Java 7u67 (and 7u25). I used the Windows handle command to see that the file was indeed being held open by a java process. I was unable to get further details about which thread was holding the file open. As this seems to be a common problem on Windows, it's not clear to me whether this is worth investigating.
awoods
pushed a commit
that referenced
this pull request
Oct 1, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specific functionality that's causing the symptom noted in PT # 79728226 was introduced via commit 068c346
Rationale for the PR:
ReadOnlyExternalPropertiesFedoraFileSystemConnectorIT fails when trying to delete a file generated when running
BasicReadWriteFedoraFileSystemConnectorIT. The former makes no use of this file, and hence shouldn't try to delete it (indirectly via AbstractFedoraFileSystemConnectorIT).
This fixes the specific build error that result from attempting to delete a file that's still held on by another Java process. The file lock was observed on Windows Java 7u67 (and 7u25). I used the Windows handle command to see that the file was indeed being held open by a java process. I was unable to get further details about which thread was holding the file open. As this seems to be a common problem on Windows, it's not clear to me whether this is worth investigating.