Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-344 #608

Closed
wants to merge 1 commit into from
Closed

TRUNK-344 #608

wants to merge 1 commit into from

Conversation

kushal8
Copy link
Contributor

@kushal8 kushal8 commented Feb 3, 2014

No description provided.

@dkayiwa
Copy link
Member

dkayiwa commented Feb 4, 2014

Can you go to the JIRA ticket and attach two screenshots showing the effects of your changes? One for long and another for short.

@dkayiwa
Copy link
Member

dkayiwa commented Feb 5, 2014

The logic for which format to use should not be in the jsp, but rather in the PersonName class.
Can you do the following:

  1. Add a static private field to the PersonName class. You could call it "format". Initialize it with the value that the global property starts with.
  2. Add a public static setter like "setFormat()"
  3. Register a GlobalPropertyListener which calls PersonName.setFormat() when the property changes. For an example of this you can look at classes like GlobalLocaleList, WebUtil, etc. Remember to register this listener in applicationContext-service.xml under bean id="openmrsEventListeners"

@dkayiwa dkayiwa closed this Feb 5, 2014
@kushal8 kushal8 deleted the TRUNK-344 branch February 6, 2014 09:43
RandilaP pushed a commit to RandilaP/openmrs-core that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants