Trnk 4140 : Substitute deprecated method call in HibernateContextDAO #788
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sashrika can you squash these commits into one? You can look for instructions at: https://wiki.openmrs.org/display/docs/Using+Git |
|
@sashrika i can reopen this when you are done with the above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed "ConfigHelper.getResourceAsStream" deprecatede method.
added junit test "should_mergeDefaultRuntimeProperties()" in ContextDAOTest.java class.
But when testing it throws java.util.ConcurrentModificationException.
as i read in http://docs.oracle.com/javase/6/docs/api/java/util/ConcurrentModificationException.html and http://stackoverflow.com/questions/1931180/how-do-i-synchronize-to-prevent-a-java-util-concurrentmodificationexception , the reason is , we change a element in a java Collection while we iterate through it .
One possible solution would be using ConcurrentHashMap. But here we use java.util.Property.
The other possible solution would be instead of changing the values while iterating through a collection, cache the changes and then copy them to the Collection.
I have used the latter approach here.