Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 007393a09d04
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 16934d921054
Choose a head ref
  • 2 commits
  • 23 files changed
  • 1 contributor

Commits on Nov 12, 2013

  1. uv: Upgrade to v0.10.19

    @tjfontaine
    tjfontaine committed Nov 12, 2013
    Copy the full SHA
    ac799ba View commit details
    Browse the repository at this point in the history

  2. src: add HandleScope in HandleWrap::OnClose 

    Fixes a 4 byte leak on handles closing. AKA The Walmart leak.

MakeCallback doesn't have a HandleScope. That means the callers scope
will retain ownership of created handles from MakeCallback and related.
There is by default a wrapping HandleScope before uv_run, if the caller
doesn't have a HandleScope on the stack the global will take ownership
which won't be reaped until the uv loop exits.

If a uv callback is fired, and there is no enclosing HandleScope in the
cb, you will appear to leak 4-bytes for every invocation. Take heed.

cc @hueniverse
    @tjfontaine
    tjfontaine committed Nov 12, 2013
    4
    Copy the full SHA
    16934d9 View commit details
    Browse the repository at this point in the history