fix jsonp rosetta flash vulnerability, see http://miki.it/blog/2014/7…

…/8/abusing-jsonp-with-rosetta-flash/
metacpan · Jul 12, 2014 · 8b1da82 · 8b1da82
1 parent acfa27a
commit 8b1da82
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/lib/MetaCPAN/Server/View/JSONP.pm b/lib/MetaCPAN/Server/View/JSONP.pm
@@ -23,7 +23,7 @@ sub process {
     if ( $content_type ne 'application/json' ) {
         $body = JSON->new->allow_nonref->ascii->encode($body);
     }
-    $c->res->body("$cb($body);");
+    $c->res->body("/**/$cb($body);");
     return 1;
 }
 

diff --git a/t/server/controller/author.t b/t/server/controller/author.t
@@ -34,7 +34,7 @@ test_psgi app, sub {
         'text/javascript; charset=UTF-8',
         'Content-type'
     );
-    like( $res->content, qr/^jsonp\(.*\);$/ms, 'includes jsonp callback' );
+    like( $res->content, qr/^\/\*\*\/jsonp\(.*\);$/ms, 'includes jsonp callback' );
 
     ok(
         $res = $cb->(

diff --git a/t/server/controller/pod.t b/t/server/controller/pod.t
@@ -59,7 +59,7 @@ test_psgi app, sub {
             'text/javascript; charset=UTF-8',
             'Content-type'
         );
-        ok( my ($function_args) = $res->content =~ /^foo\((.*)\)/s,
+        ok( my ($function_args) = $res->content =~ /^\/\*\*\/foo\((.*)\)/s,
             'callback included' );
         ok( my $jsdata = JSON->new->allow_nonref->decode($function_args),
             'decode json' );

diff --git a/t/server/controller/source.t b/t/server/controller/source.t
@@ -49,7 +49,7 @@ test_psgi app, sub {
                     )
             );
             if ( $k =~ /callback=foo/ ) {
-                ok( my ($function_args) = $res->content =~ /^foo\((.*)\)/s,
+                ok( my ($function_args) = $res->content =~ /^\/\*\*\/foo\((.*)\)/s,
                     'JSONP wrapper' );
                 ok(
                     my $jsdata
@@ -90,7 +90,7 @@ test_psgi app, sub {
                 'text/javascript; charset=UTF-8',
                 'Content-type'
             );
-            ok( my ($function_args) = $res->content =~ /^foo\((.*)\)/s,
+            ok( my ($function_args) = $res->content =~ /^\/\*\*\/foo\((.*)\)/s,
                 'JSONP wrapper' );
             ok(
                 my $jsdata = JSON->new->allow_nonref->decode($function_args),