Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 4234bcce486f
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: a2d1cbef6baa
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Oct 16, 2013

  1. dns: rename domain to hostname 

    A follow-up commit will save the domain name on the request object but
we can't call that property 'domain' because that gets intercepted by
src/node.cc and lib/domain.js to implement the node.js feature of the
same name.

To avoid confusion, rename all variables called 'domain' to 'hostname'.
    @bnoordhuis
    bnoordhuis committed Oct 16, 2013
    Copy the full SHA
    ceb8740 View commit details
    Browse the repository at this point in the history

  2. dns: set hostname property on error object 

    Make debugging and logging easier: when a DNS lookup for a hostname
fails, set the hostname as a property on the error object.

Fixes #5393.
    @bnoordhuis
    bnoordhuis committed Oct 16, 2013
    Copy the full SHA
    a2d1cbe View commit details
    Browse the repository at this point in the history