Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PMs] Random refactoring #579

Closed
wants to merge 13 commits into from
Closed

[PMs] Random refactoring #579

wants to merge 13 commits into from

Conversation

emanuele45
Copy link
Contributor

  • PM controller refactoring. Make a few subs utilities functions.
  • Fixes to existing subs.

@emanuele45
Used subs for PM controller (the function was there, refined a bit)
2caf7f2 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
A function to load membergroups details...I wonder why this function …
a6c55eb 
…didn't exist yet...did I miss it?

Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
getMemberByName reused in PM controller and removed fatal error from …
80bb1f7 
…the function

Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Not exactly sure what is used for, but $sort_by_query was always pm.i…
97b7119 
…d_pm due to missing break in switch

Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Unconverted $context to $pm_options
446a57f 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
A function to retrieve the discussion id from a pm id and one to get all
1e2f53a 
the pm IDs in a discussion

Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Seems more readable
62be0ec 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Make action_pmactions query-free
321554b 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
A function to retrieve all the PMs older than a certain date
c9aada0 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Copy link
Contributor Author

Fixed the two unsigned (and with meaningful messages) commits

@emanuele45
Couple of missing things (some my falt some not :P)
9fd0ebe 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Merge branch 'master' into random_refactoring
de84023 
Conflicts:
	sources/admin/ManagePaid.php
@emanuele45
Added accessibleGroups, it should work, not tested
a308bbf 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Removed unused var - thanks Norv
1e28fac 
Signed-off-by: emanuele <emanuele45@gmail.com>
@norv
Copy link
Contributor

norv commented Jul 19, 2013

Oh, well. I have already taken the branch in. :)
I have rebased both your latest two PRs. (I hope I didn't break them! Looks like I like doing that today.)
I prefer rebase over merge, in particular now that we had relatively big merges. ;)

@norv norv closed this Jul 19, 2013
@emanuele45
Copy link
Contributor Author

I didn't rebase these two in particular not to break all the comments here at github, they tend to go messy with rebases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emanuele45 @norv