Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
base: 8d35e57a9977
Choose a base ref
...
head repository: mantisbt/mantisbt
compare: f9b9e2fc4356
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Jul 3, 2012

  1. Fix system warning in html_status_legend() with custom status 

    When using custom status for which no language strings are defined,
html_status_legend() triggered system warnings.

MantisBT now displays the custom status' name as defined in the enum,
in case there is no available translation string.

Fixes #14446
    @dregad
    dregad committed Jul 3, 2012
    Copy the full SHA
    123c2c8 View commit details
    Browse the repository at this point in the history

  2. Add param to bug_resolve() to allow "resolution" to custom status 

    Function bug_resolve() sets the status to bug_resolved_status_threshold.
This behavior is fine with MantisBT's default status enum, but is
causing issues when using a custom target status that is
>= $g_bug_resolved_status_threshold & < $g_bug_closed_status_threshold.

In this case, when changing status using the button on view.php, the
target status selected by the user is overriden by the value of
bug_resolved_status_threshold, resulting in incorrect behavior. The only
way to effectively reach the custom state is by editing the issue.

To address this, a new optional parameter $p_status is added to
bug_resolve(). To make the function call more logical, the signature was
modified: new parameter inserted in 3rd position after $p_resolution.

The function's phpdoc header has been completed.

Fixes #14443
    @dregad
    dregad committed Jul 3, 2012
    Copy the full SHA
    91a99d9 View commit details
    Browse the repository at this point in the history

  3. Code cleanup in bug_update.php 

    Fixes whitespace, code alignment, typos in comments, long lines
    @dregad
    dregad committed Jul 3, 2012
    Copy the full SHA
    f9b9e2f View commit details
    Browse the repository at this point in the history