Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: fcrepo/fcrepo
base: 72095d989715
Choose a base ref
...
head repository: fcrepo/fcrepo
compare: 4e33fd2fa361
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 1, 2014

  1. Remove unnecessary clean up of file in test. 

    The specific functionality that's causing the symptom noted in PT # 79728226 was introduced via commit 068c346

Rationale for the PR:

ReadOnlyExternalPropertiesFedoraFileSystemConnectorIT fails when trying to delete a file generated when running
BasicReadWriteFedoraFileSystemConnectorIT. The former makes no use of this file, and hence shouldn't try to delete it (indirectly via AbstractFedoraFileSystemConnectorIT).

This fixes the specific build error that result from attempting to delete a file that's still held on by another Java process. The file lock was observed on Windows Java 7u67 (and 7u25). I used the Windows handle command to see that the file was indeed being held open by a java process. I was unable to get further details about which thread was holding the file open. As this seems to be a common problem on Windows, it's not clear to me whether this is worth investigating.
    @osmandin
    osmandin committed Oct 1, 2014
    Copy the full SHA
    c9e329e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #494 from osmandin/79728226 

    https://www.pivotaltracker.com/story/show/79728226
    Andrew Woods committed Oct 1, 2014
    Copy the full SHA
    4e33fd2 View commit details
    Browse the repository at this point in the history