Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: e2acf26a91c6
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 2cbf4586df83
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jan 23, 2013

  1. http: close connection on 304 and chunked encoding 

    Force the connection to close when the response is a 304 Not Modified
and the user has set a "Transfer-Encoding: chunked" header.

RFC 2616 mandates that 304 responses MUST NOT have a body but node.js
used to send out a zero chunk anyway to accommodate clients that don't
have special handling for 304 responses.

It was pointed out that this might confuse reverse proxies to the point
of creating security liabilities, so suppress the zero chunk and force
the connection to close.
    @bnoordhuis
    bnoordhuis committed Jan 23, 2013
    Copy the full SHA
    2cbf458 View commit details
    Browse the repository at this point in the history