Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: bb431531a374
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: c11612026fa2
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Mar 1, 2013

  1. net: omit superfluous 'connect' event 

    Don't emit a 'connect' event on sockets that are handed off to
net.Server 'connection' event listeners.

1. It's superfluous because the connection has already been established
   at that point.

2. The implementation is arguably wrong because the event is emitted on
   the same tick of the event loop while the rule of thumb is to always
   emit it on the next one.

This has been tried before in commit f0a440d but was reverted again in
ede1acc because the change was incomplete (at least one test hadn't
been updated).

Fixes #1047 (again).
    @bnoordhuis
    bnoordhuis committed Mar 1, 2013
    Copy the full SHA
    c116120 View commit details
    Browse the repository at this point in the history