New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #372
Fixes #372
Conversation
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Have a look at emanuele45@3ec203a and the change in Subs.php I think it should be safe. |
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
No good idea. If this is the only change I guess it's perfectly fine... Eventually a comment on the XML return stuff, for us to know why is that there when we wake up tomorrowz? 👼 |
Signed-off-by: emanuele <emanuele45@gmail.com>
Maybe this will teach Norv to do small changes... probably not ;) |
Signed-off-by: emanuele <emanuele45@gmail.com>
Well... I was actually going to make something like double or more of these changes (fixes included!!). Got a little more derailed though... Sorry about this. These wide scale refactorings, even basic, are always like that I'm afraid. |
Signed-off-by: emanuele <emanuele45@gmail.com>
Thank you! This batch has been greatly useful, Ema. Perhaps we can dare to pull master now... 👼 |
I'm working on several others.
Double check: emanuele45@36abbff