Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #372

Merged
merged 15 commits into from May 8, 2013
Merged

Fixes #372

merged 15 commits into from May 8, 2013

Conversation

emanuele45
Copy link
Contributor

I'm working on several others.
Double check: emanuele45@36abbff

Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Copy link
Contributor Author

Have a look at emanuele45@3ec203a and the change in Subs.php I think it should be safe.
This is related to the change I did few days ago adding the two variables in template_init to style the page index and the numbers next to the menu entries, when in XML index.template.php is not loaded and these settings are empty.
Maybe it is better to have them anyway somewhere? Or let the function finish all the processing checking if these values are empty or not?

Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
@norv
Copy link
Contributor

norv commented May 8, 2013

Have a look at emanuele45/Dialogo@3ec203a and the change in Subs.php I think it should be safe.
This is related to the change I did few days ago adding the two variables in template_init to style the page index and the numbers next to the menu entries, when in XML index.template.php is not loaded and these settings are empty.
Maybe it is better to have them anyway somewhere? Or let the function finish all the processing checking if these values are empty or not?

No good idea. If this is the only change I guess it's perfectly fine... Eventually a comment on the XML return stuff, for us to know why is that there when we wake up tomorrowz? 👼

Signed-off-by: emanuele <emanuele45@gmail.com>
@joshuaadickerson
Copy link
Contributor

Maybe this will teach Norv to do small changes... probably not ;)

Signed-off-by: emanuele <emanuele45@gmail.com>
@norv
Copy link
Contributor

norv commented May 8, 2013

Well... I was actually going to make something like double or more of these changes (fixes included!!). Got a little more derailed though... Sorry about this. These wide scale refactorings, even basic, are always like that I'm afraid.

Signed-off-by: emanuele <emanuele45@gmail.com>
norv added a commit that referenced this pull request May 8, 2013
@norv norv merged commit fb34c04 into elkarte:master May 8, 2013
@norv
Copy link
Contributor

norv commented May 8, 2013

Thank you! This batch has been greatly useful, Ema. Perhaps we can dare to pull master now... 👼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants