Implement Enumerable#reverse_each

opal · Dec 14, 2013 · aeee689 · aeee689
1 parent 7dae682
commit aeee689
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -86,8 +86,8 @@
 *   Fix various `Struct` methods. Fixed `#each` and `#each_pair` to return
     self. Add `Struct.[]` as synonym for `Struct.new`.
 
-*   Implemented some `Enumerable` methods: `#collect_concat`, `#flat_map` and
-    `#reject`.
+*   Implemented some `Enumerable` methods: `#collect_concat`, `#flat_map`,
+    `#reject` and `#reverse_each`.
 
 ## 0.5.5 2013-11-25
 

diff --git a/opal/corelib/enumerable.rb b/opal/corelib/enumerable.rb
@@ -970,8 +970,25 @@ def reject(&block)
       return result;
     }
   end
+
   def reverse_each(&block)
-    raise NotImplementedError
+    return enum_for :reverse_each unless block_given?
+
+    %x{
+      var result = [];
+
+      self.$each._p = function() {
+        result.push(arguments);
+      };
+
+      self.$each();
+
+      for (var i = result.length - 1; i >= 0; i--) {
+        $opal.$yieldX(block, result[i]);
+      }
+
+      return result;
+    }
   end
 
   alias select find_all

diff --git a/spec/opal/filters/bugs/enumerable.rb b/spec/opal/filters/bugs/enumerable.rb
@@ -53,8 +53,6 @@
   fails "Enumerable#partition returns two arrays, the first containing elements for which the block is true, the second containing the rest"
 
   fails "Enumerable#reverse_each gathers whole arrays as elements when each yields multiple"
-  fails "Enumerable#reverse_each returns an Enumerator if no block given"
-  fails "Enumerable#reverse_each traverses enum in reverse order and pass each element to block"
 
   fails "Enumerable#sort gathers whole arrays as elements when each yields multiple"
   fails "Enumerable#sort raises an error if objects can't be compared"