Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I/O calls do not invalidate String#ascii_only? cache #2316

Closed
ghost opened this issue Dec 13, 2014 · 2 comments
Closed

I/O calls do not invalidate String#ascii_only? cache #2316

ghost opened this issue Dec 13, 2014 · 2 comments
Labels
core encoding JRuby 1.7.x
Milestone
JRuby 1.7.18

Comments

@ghost
Copy link

ghost commented Dec 13, 2014

See rubinius/rubinius#3236 reproducable with JRuby 1.7.17 and master.
@headius
Copy link
Member

headius commented Dec 15, 2014

Thanks to you and @FooBarWidget for finding this! It also appears to reproduce on JRuby master, which is surprising since I have re-ported much of the IO and encoding logic.

Definitely a big one to fix for 1.7.18.

@headius headius added this to the JRuby 1.7.18 milestone Dec 15, 2014
@headius
Copy link
Member

headius commented Dec 15, 2014

Fixed on master. I'll try to make same fix on 1.7 now.

evanphx pushed a commit to ruby/ruby that referenced this issue Dec 15, 2014
* test/ruby/test_io_m17n.rb: Add test for coderange clearing in
0f99627 
  IO#read with buffer. See jruby/jruby#2316.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
headius added a commit that referenced this issue Dec 15, 2014
@headius
Clear code range when modify/expanding string for IO.read(..,buf).
fc05939 
Fixes #2316.

Test added to MRI in http://mla.n-z.jp/~w3ml/w3ml.cgi/ruby-changes/msg/36766
@FooBarWidget FooBarWidget mentioned this issue Dec 15, 2014
Closed
ayumin pushed a commit to ayumin/ruby that referenced this issue Jan 4, 2015
* test/ruby/test_io_m17n.rb: Add test for coderange clearing in
b6e77df 
  IO#read with buffer. See jruby/jruby#2316.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mmasaki pushed a commit to mmasaki/ruby that referenced this issue May 30, 2015
* test/ruby/test_io_m17n.rb: Add test for coderange clearing in
6a2434c 
  IO#read with buffer. See jruby/jruby#2316.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48847 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core encoding JRuby 1.7.x
Projects
None yet
Milestone
JRuby 1.7.18
Development

No branches or pull requests
1 participant
@headius