Fixing order for other metadata. #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are you aware of http://plugins.getnikola.com/#tags ? |
| @@ -1241,8 +1242,8 @@ def write_metadata(data): | |||
| pass | |||
|
|
|||
| # Leftover metadata (user-specified/non-default). | |||
| for k, v in data.items(): | |||
| meta.append(f.format(k, v)) | |||
| for k in natsort.natsorted(list(data.keys())): | |||
There was a problem hiding this comment.
for k in natsort.natsorted(list(data.keys()), alg=natsort.ns.F | natsort.ns.IC):
|
No, I wasn't aware of that plugin. Looks like that does most of what I wanted to do :) (I originally started writing my plugin to have something nice to get a list of all tags with number of use; I only later got the idea to add tag rename/... support. Well, no need to work that out, then.) |
|
Ok, added your suggestion. Using the additional |
Kwpolska
added a commit
that referenced
this pull request
Jan 18, 2015
Fixing order for other metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the order of metadata written via
utils.write_metadata(). Currently, a 'random' order (induced by the dict used) is taken.I'm currently working on a small tag management plugin, which needs to read and write metadata. I want to avoid that every time the tags are modified, other metadata ends up in a new random order.