net: defer net.Server 'close' event to next tick

nodejs · Dec 29, 2011 · c24276f · c24276f
1 parent 0c3b357
commit c24276f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/lib/net.js b/lib/net.js
@@ -862,9 +862,13 @@ Server.prototype.close = function() {
 };
 
 Server.prototype._emitCloseIfDrained = function() {
-  if (!this._handle && !this.connections) {
-    this.emit('close');
-  }
+  var self = this;
+
+  if (self._handle || self.connections) return;
+
+  process.nextTick(function() {
+    self.emit('close');
+  });
 };
 
 

diff --git a/test/simple/test-net-server-listen-remove-callback.js b/test/simple/test-net-server-listen-remove-callback.js
@@ -34,6 +34,9 @@ server.on('close', function() {
 
 server.listen(common.PORT, function() {
   server.close();
+});
+
+server.once('close', function() {
   server.listen(common.PORT + 1, function() {
     server.close();
   });