Fix #14420: system warning in make_captcha

dregad · dregad · commit 1b79a041ad2c · 2012-06-26T12:42:17.000+02:00
Per PHP documentation [1], second param of imagejpeg() should be set to null to output the image directly. Thanks to Andrew Kovalenko for noticing and providing fix for the issue [1] http://php.net/imagejpeg
diff --git a/make_captcha_img.php b/make_captcha_img.php
@@ -246,7 +246,7 @@ function make_captcha( $private_key )
 					$x += (int)($size + ($this->minsize / 5));
 				}
 				header('Content-type: image/jpeg');
-				@ImageJPEG($image, '', $this->jpegquality);
+				@ImageJPEG($image, null, $this->jpegquality);
 				@ImageDestroy($image);
 				if($this->debug) echo "\n<br />-Captcha-Debug: Destroy Imagestream.";
 			}

Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ function make_captcha( $private_key )`
`246`	`246`	`$x += (int)($size + ($this->minsize / 5));`
`247`	`247`	`}`
`248`	`248`	`header('Content-type: image/jpeg');`
`249`		`- @ImageJPEG($image, '', $this->jpegquality);`
	`249`	`+ @ImageJPEG($image, null, $this->jpegquality);`
`250`	`250`	`@ImageDestroy($image);`
`251`	`251`	`if($this->debug) echo "\n<br />-Captcha-Debug: Destroy Imagestream.";`
`252`	`252`	`}`