Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: metacpan/metacpan-web
base: 091fcaed69e7
Choose a base ref
...
head repository: metacpan/metacpan-web
compare: e4f3075f33f0
Choose a head ref
  • 7 commits
  • 4 files changed
  • 2 contributors

Commits on May 17, 2014

  1. Delay loading of dependency graph until it is shown.

    When the modal is shown, then we set the "src" attribute
    of the iframe, which causes the browser to load the content.
    We only do this the first time the modal is shown, because
    the src will be the same for any given page. Fixes GH #1179.
    thaljef committed May 17, 2014
    Copy the full SHA
    216882c View commit details
    Browse the repository at this point in the history
  2. More readable code, perhaps.

    thaljef committed May 17, 2014
    Copy the full SHA
    c66b8d3 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2014

  1. Added header to dependency graph modal.

    It includes the release name and a button to close the modal.
    thaljef committed May 19, 2014
    Copy the full SHA
    d6d9822 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    dd5557c View commit details
    Browse the repository at this point in the history

Commits on May 20, 2014

  1. Copy the full SHA
    67940b2 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2014

  1. Change dependency graph link to a button. Fixes GH #1195.

    Displaying the dependency graph modal isn't really
    a "navagation" event.  So it is more appropriate to
    implement this as a <button> rather than an <a> link.
    
    However, Bootstrap has slightly different styling for
    buttons, so I had to add a bit of CSS to make this particular
    button look just like the neighboring links.
    
    I also moved the modal <div> outside the <ul> since it wasn't
    strictly valid, and it makes the markup easier to understand
    when/if you need to look at the page source.
    thaljef committed May 22, 2014
    Copy the full SHA
    8f46fc5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1187 from Stratopan/master

    Delay loading of dependency graph until it is shown.
    oalders committed May 22, 2014
    Copy the full SHA
    e4f3075 View commit details
    Browse the repository at this point in the history