Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: 53bc775ea818
Choose a base ref
...
head repository: cdk/cdk
compare: 15ecad171904
Choose a head ref
  • 6 commits
  • 7 files changed
  • 1 contributor

Commits on Mar 24, 2013

  1. using reflection to correct unit test. Unit test order is non certain… 

    … and so in this test the template may already be loaded (fail) - to avoid this we use reflection to create a new non-singleton instance and to excite the private loading of templates.

Change-Id: I7b4467e006065e234138d0a577ab0d42c956d691
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Mar 24, 2013
    Copy the full SHA
    efce85c View commit details
    Browse the repository at this point in the history

  2. resolved three unit test errors in cdk-builder3d, due to the SINGLE_O… 

    …R_DOUBLE flag which if not erased was leading to different atom types and thus fingerprints when searching for templates.

Change-Id: Icbbdeee7f97f7e85c56c2b81eada5df157d766b6
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Mar 24, 2013
    Copy the full SHA
    f50a040 View commit details
    Browse the repository at this point in the history

  3. replaced manipulator produce anonymous structures - the new method av… 

    …oids cloning so all values will always be default and avoids issues from the previous commit

Change-Id: Ib8b2d75f53ffc7011d70e6a46e4047a2d9f8b858
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Mar 24, 2013
    Copy the full SHA
    3b8438f View commit details
    Browse the repository at this point in the history

  4. corrected assertion, refer to data added in: commit deebfab 

    Change-Id: I00b0481b39df11774167fbfc97ea0b61dcfc2325
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Mar 24, 2013
    Copy the full SHA
    e844cbc View commit details
    Browse the repository at this point in the history

  5. corrected assertion to compare correct values, an IBitFingerprint (70… 

    …04511) cannot be comapred with an BitSet

Change-Id: I4d32f66de4cbca161f73ae0bb0c73e92a4f4ebaf
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Mar 24, 2013
    Copy the full SHA
    7fa4a3a View commit details
    Browse the repository at this point in the history

  6. updated unit test assertions to match the fingerprinter that was chan… 

    …ged in b27ee12

Change-Id: I304de86d0425314e5ff64383b950979863a9a980
Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    @johnmay @egonw
    johnmay authored and egonw committed Mar 24, 2013
    Copy the full SHA
    15ecad1 View commit details
    Browse the repository at this point in the history