Serialize incoming RDF properties to JCR Strings #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (type == UNDEFINED | ||
| || type == STRING | ||
| || (data.isResource() && type != URI && type != REFERENCE && type != WEAKREFERENCE)) { | ||
|
|
There was a problem hiding this comment.
We could make a Set of the types we don't want to engage and a clearer test.
cbeer
force-pushed
the
jcr-string-values
branch
from
71006e2
to
5fe6b25
Compare
|
If we are not storing values as JCR types, is the translation from JCR types to RDF types found in ValueConverter.doForward() any longer necessary? |
awoods
pushed a commit
that referenced
this pull request
Nov 6, 2014
Serialize incoming RDF properties to JCR Strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/82228452