Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 24856f04b23e
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 262a752c2943
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Jan 17, 2014

  1. tls: show human-readable error messages

    Before this commit, verification exceptions had err.message set to the
    OpenSSL error code (e.g. 'UNABLE_TO_VERIFY_LEAF_SIGNATURE').
    
    This commit moves the error code to err.code and replaces err.message
    with a human-readable error.  Example:
    
        // before
        {
          message: 'UNABLE_TO_VERIFY_LEAF_SIGNATURE'
        }
    
        // after
        {
          code: 'UNABLE_TO_VERIFY_LEAF_SIGNATURE',
          message: 'unable to verify the first certificate'
        }
    
    UNABLE_TO_VERIFY_LEAF_SIGNATURE is a good example of why you want this:
    the error code suggests that it's the last certificate that fails to
    validate while it's actually the first certificate in the chain.
    
    Going by the number of mailing list posts and StackOverflow questions,
    it's a source of confusion to many people.
    bnoordhuis authored and indutny committed Jan 17, 2014
    Copy the full SHA
    262a752 View commit details
    Browse the repository at this point in the history