Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 3dbbfd78030d
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: fb3ec32b0ea5
Choose a head ref
  • 3 commits
  • 7 files changed
  • 1 contributor

Commits on Mar 6, 2013

  1. handle_wrap: replace unref_ field with flags_ field 

    Prep work for a follow-up commit that adds support for close callbacks.
    @bnoordhuis
    bnoordhuis committed Mar 6, 2013
    Copy the full SHA
    3d20905 View commit details
    Browse the repository at this point in the history

  2. handle_wrap: add close callback support

    @bnoordhuis
    bnoordhuis committed Mar 6, 2013
    Copy the full SHA
    958ab66 View commit details
    Browse the repository at this point in the history

  3. net: use close callback, not process.nextTick 

    Don't emit the 'close' event with process.nextTick.

Closing a handle is an operation that usually *but not always* completes
on the next tick of the event loop, hence using process.nextTick is not
reliable.

Use a proper handle close callback and emit the 'close' event from
inside the callback.

Update tests that depend on the intricacies of the old model.

Fixes #3459.
    @bnoordhuis
    bnoordhuis committed Mar 6, 2013
    Copy the full SHA
    fb3ec32 View commit details
    Browse the repository at this point in the history