stash key shortcuts do not need to return the invocant

mojolicious · Sep 12, 2014 · 3d50d55 · 3d50d55
1 parent b480d06
commit 3d50d55
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/Mojolicious/Plugin/DefaultHelpers.pm b/lib/Mojolicious/Plugin/DefaultHelpers.pm
@@ -20,9 +20,8 @@ sub register {
     $app->helper(
       $name => sub {
         my $c = shift;
-        return return $c->stash->{$name} unless @_;
-        $c->stash($name => shift, @_);
-        return $c;
+        $c->stash($name => shift, @_) if @_;
+        return $c->stash->{$name};
       }
     );
   }

diff --git a/t/mojolicious/layouted_lite_app.t b/t/mojolicious/layouted_lite_app.t
@@ -28,7 +28,7 @@ hook after_render => sub {
 # Default layout for whole application
 app->defaults(layout => 'default');
 
-get '/works' => sub { shift->title('Just works')->render };
+get '/works';
 
 get '/mixed';
 
@@ -287,6 +287,7 @@ Mixed <%= content %>
 Blue<%= title %><%= content %>
 
 @@ works.html.ep
+% title 'Just works';
 % layout 'green' if param 'green';
 % extends 'blue' if param 'blue';
 This <template> just works!