added a few more Mojo::Date tests

mojolicious · Oct 5, 2011 · fcf95c8 · fcf95c8
1 parent 422e851
commit fcf95c8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/lib/Mojo/Date.pm b/lib/Mojo/Date.pm
@@ -13,10 +13,7 @@ has 'epoch';
 my @DAYS   = qw/Sun Mon Tue Wed Thu Fri Sat/;
 my @MONTHS = qw/Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec/;
 my %MONTHS;
-{
-  my $i = 0;
-  $MONTHS{$_} = $i++ for @MONTHS;
-}
+@MONTHS{@MONTHS} = (0 .. 11);
 
 sub new { shift->SUPER::new->parse(@_) }
 

diff --git a/t/mojo/date.t b/t/mojo/date.t
@@ -1,7 +1,7 @@
 #!/usr/bin/env perl
 use Mojo::Base -strict;
 
-use Test::More tests => 17;
+use Test::More tests => 21;
 
 # "Can't we have one meeting that doesn't end with digging up a corpse?"
 use_ok 'Mojo::Date';
@@ -25,10 +25,17 @@ is Mojo::Date->new('Fri May 13 10:00:24 2011')->epoch,
   1305280824, 'right epoch value';
 
 # Invalid string
+is Mojo::Date->new('')->epoch,        undef, 'no epoch value';
 is Mojo::Date->new('123 abc')->epoch, undef, 'no epoch value';
 is Mojo::Date->new('abc')->epoch,     undef, 'no epoch value';
 is Mojo::Date->new('Xxx, 00 Xxx 0000 00:00:00 XXX')->epoch, undef,
   'no epoch value';
+is Mojo::Date->new('Sun, 06 Nov 1994 08:49:37 GMT GARBAGE')->epoch, undef,
+  'no epoch value';
+is Mojo::Date->new('Sunday, 06-Nov-94 08:49:37 GMT GARBAGE')->epoch, undef,
+  'no epoch value';
+is Mojo::Date->new('Sun Nov  6 08:49:37 1994 GARBAGE')->epoch, undef,
+  'no epoch value';
 
 # to_string
 $date = Mojo::Date->new(784111777);