Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 8b0f3ce397b4
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 6b713b52537f
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jan 18, 2013

  1. cluster: make --prof work for workers

    Profiling in clustered environments doesn't work out of the box.
    
    By default, V8 writes the profile data of all processes to a single
    v8.log.
    
    Running that log file through a tick processor produces bogus numbers
    because many events won't match up with the recorded memory mappings
    and you end up with graphs where 80+% of ticks is unaccounted for.
    
    Fixing the tick processor to deal with multi-process output is not very
    useful because the processes may be running wildly disparate workloads.
    
    That's why we fix up the command line arguments to include
    a "--logfile=v8-%p.log" argument (where %p is expanded to the PID)
    unless it already contains a --logfile argument.
    
    Fixes #4617.
    bnoordhuis committed Jan 18, 2013
    Copy the full SHA
    6b713b5 View commit details
    Browse the repository at this point in the history