Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 6ecb0cd65d2f
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: d2e7ca044929
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Dec 25, 2012

  1. net: allow socket end before connect 

    Fix a bug where calling .end() on a socket without calling .connect() first
throws a TypeError:

  TypeError: Cannot read property 'shutdown' of undefined
      at Socket.onSocketFinish (net.js:194:20)
      at Socket.EventEmitter.emit (events.js:91:17)
      at Socket.Writable.end (_stream_writable.js:281:10)
      at Socket.end (net.js:352:31)

Fixes #4463.
    @bentaber @bnoordhuis
    bentaber authored and bnoordhuis committed Dec 25, 2012
    Copy the full SHA
    526d852 View commit details
    Browse the repository at this point in the history

  2. test: add regression test for #4463

    @bnoordhuis
    bnoordhuis committed Dec 25, 2012
    Copy the full SHA
    d2e7ca0 View commit details
    Browse the repository at this point in the history