Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dac366dd594c
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cce55de68d92
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Dec 29, 2014

  1. Remove no longer used constructor

    @enebo
    enebo committed Dec 29, 2014
    Copy the full SHA
    f48d629 View commit details

  2. Fail fast if we see anything other than the four expected node types … 

    …in call args
    @enebo
    enebo committed Dec 29, 2014
    Copy the full SHA
    cce55de View commit details
Showing with 1 addition and 7 deletions.
  1. +0 −5 core/src/main/java/org/jruby/ast/CallNode.java
  2. +1 −2 core/src/main/java/org/jruby/ir/IRBuilder.java
5 changes: 0 additions & 5 deletions core/src/main/java/org/jruby/ast/CallNode.java
View file
Original file line number Diff line number Diff line change
@@ -47,11 +47,6 @@ public class CallNode extends Node implements INameNode, IArgumentNode, BlockAcc
protected Node iterNode;
private String name;

@Deprecated
public CallNode(ISourcePosition position, Node receiverNode, String name, Node argsNode) {
this(position, receiverNode, name, argsNode, null);
}

public CallNode(ISourcePosition position, Node receiverNode, String name, Node argsNode,
Node iterNode) {
super(position);
3 changes: 1 addition & 2 deletions core/src/main/java/org/jruby/ir/IRBuilder.java
View file
Original file line number Diff line number Diff line change
@@ -599,8 +599,7 @@ protected Operand buildCallArgs(List<Operand> argsList, Node args, IRScope s) {
break;
}
default: {
argsList.add(build(args, s));
break;
throw new NotCompilableException("Use buildRoot(); Root node at: " + args.getPosition());
}
}