Prune old notifications (not replies or dms) after a certain amount a…

…re read
RedEnchilada · Dec 20, 2014 · d74a164 · d74a164
1 parent 79679c5
commit d74a164
Showing 1 changed file with 19 additions and 1 deletion.
diff --git a/plugins/Notification/User_notification.php b/plugins/Notification/User_notification.php
@@ -6,6 +6,8 @@
 
 require_once INSTALLDIR . '/classes/Memcached_DataObject.php';
 
+define('MAX_NOTIFICATIONS_PER_USER', 64);
+
 class User_notification extends Memcached_DataObject
 {
     public $__table = 'user_notification'; // table name
@@ -79,7 +81,10 @@ function keyTypes()
 	static function getAllForUser($user) {
 		$notify = new User_notification();
 		$notify->user_id = $user->id;
-		if(!$notify->find())
+        $notify->orderBy('id ASC');
+
+		$noteCount = $notify->find();
+		if(!$noteCount)
 			return false;
 
 		$return = array();
@@ -88,13 +93,23 @@ static function getAllForUser($user) {
 				$return[$notify->type] = array();
 			$item = array();
 
+			// Prune "unimportant" (not replies or DMs) notes when we go over the limit
+			if ($noteCount > MAX_NOTIFICATIONS_PER_USER && !(
+				$notify->type == 'mention' || $notify->type == 'message'
+			)) {
+				$notify->delete();
+				$noteCount--;
+				continue;
+			}
+
 			$item['type'] = $notify->type;
 			$item['id'] = $notify->id;
 			$item['created'] = $notify->created;
 
 			$other = Profile::staticGet('id', $notify->from_user_id);
 			if($other == false) {
 				$notify->delete();
+				$noteCount--;
 				continue;
 			}	
 			$item['user'] = array(
@@ -111,6 +126,7 @@ static function getAllForUser($user) {
 				if($notice == false) {
 					$item = null;
 					$notify->delete();
+					$noteCount--;
 					break;
 				}
 				$item['notice'] = array(
@@ -127,6 +143,7 @@ static function getAllForUser($user) {
 				if($notice == false) {
 					$item = null;
 					$notify->delete();
+					$noteCount--;
 					break;
 				}
 				$item['notice'] = array(
@@ -142,6 +159,7 @@ static function getAllForUser($user) {
 				if($group == false) {
 					$item = null;
 					$notify->delete();
+					$noteCount--;
 					break;
 				}
 				$item['group'] = array(