Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: d12166ab2aa7
Choose a base ref
...
head repository: cdk/cdk
compare: 52330f442307
Choose a head ref
  • 9 commits
  • 43 files changed
  • 1 contributor

Commits on Dec 15, 2014

  1. Fixed a PMD warning: final static vars should have fully capatalized … 

    …names

Change-Id: Ife64671a946ffda202c35a79e94b0f5096a0fcf7

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Dec 15, 2014
    Copy the full SHA
    df75599 View commit details
    Browse the repository at this point in the history

  2. Removed a private, unused variable 

    Change-Id: I60ebac75237655fcfe5ea553c92fe04f46449c4e

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Dec 15, 2014
    Copy the full SHA
    e375961 View commit details
    Browse the repository at this point in the history

  3. Fixed a PMD warning: removed an underscore from a non-final var 

    Change-Id: I36bd56a172ae92259b6935aca6875f3db6f2026f

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Dec 15, 2014
    Copy the full SHA
    cc1609e View commit details
    Browse the repository at this point in the history

  4. Removed dead code 

    Change-Id: I52eeedcd2e3e15953d60d1abb6131c1bfadfb0da

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Dec 15, 2014
    Copy the full SHA
    feab2b2 View commit details
    Browse the repository at this point in the history

  5. Fixed a PMD warning: final static vars should have fully capatalized … 

    …names

Change-Id: I2404c85a8c5fe55ae7837da88363bd68a2a38a33

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Dec 15, 2014
    Copy the full SHA
    ceef23c View commit details
    Browse the repository at this point in the history

  6. Fixed a PMD warning: removed an underscore from a non-final var 

    Change-Id: I22f17b64ebb97b605402b6636bfa02be5fcb1ac9

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Dec 15, 2014
    Copy the full SHA
    5282618 View commit details
    Browse the repository at this point in the history

  7. Fixed a PMD warning: removed an underscore from a non-final var 

    Change-Id: I1a7bdaec31884988b96ac4701eb1535ae73a948d

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Dec 15, 2014
    Copy the full SHA
    59460f0 View commit details
    Browse the repository at this point in the history

  8. Fixed a PMD warning: fixed variable names (start with lower case char… 

    …; length)

Change-Id: Ia56545bd216a7470d607d5e8bb797c25d11d304d

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Dec 15, 2014
    Copy the full SHA
    121435f View commit details
    Browse the repository at this point in the history

  9. Adhere to variable name conventions 

    Change-Id: I0fdaef25bb3ec54adc2e31cd9d7991ad8593373c

Signed-off-by: John May <john.wilkinsonmay@gmail.com>
    @egonw @johnmay
    egonw authored and johnmay committed Dec 15, 2014
    Copy the full SHA
    52330f4 View commit details
    Browse the repository at this point in the history