small optimizations

mojolicious · Dec 14, 2012 · f5482b3 · f5482b3
1 parent a4ac04b
commit f5482b3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/lib/Mojolicious/Types.pm b/lib/Mojolicious/Types.pm
@@ -44,16 +44,13 @@ sub detect {
   return [] if !$prioritize && @types > 1;
 
   # Detect extensions from MIME types
-  my @exts;
+  my %reverse;
   my $types = $self->types;
-  for my $type (@types) {
-    for my $ext (sort keys %$types) {
-      my @types = ref $types->{$ext} ? @{$types->{$ext}} : ($types->{$ext});
-      $type eq $_ and push @exts, $ext for map { s/\;.*$//; lc $_ } @types;
-    }
+  for my $ext (sort keys %$types) {
+    my @types = ref $types->{$ext} ? @{$types->{$ext}} : ($types->{$ext});
+    push @{$reverse{$_}}, $ext for map { s/\;.*$//; lc $_ } @types;
   }
-
-  return \@exts;
+  return [map { @{$reverse{$_} // []} } @types];
 }
 
 sub type {

diff --git a/t/mojolicious/types.t b/t/mojolicious/types.t
@@ -77,5 +77,7 @@ is_deeply $t->detect(' TEXT/HTML , text/plain;Q=0.9', 1),
   ['htm', 'html', 'txt'], 'right formats';
 is_deeply $t->detect('text/plain;q=0.5, text/xml, application/xml;q=0.1', 1),
   ['xml', 'txt', 'xml'], 'right formats';
+is_deeply $t->detect('application/json, text/javascript, */*; q=0.01', 1),
+  ['json'], 'right formats';
 
 done_testing();