Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ripper is still 2.0 grammar and has not been updated for 2.2 changes #2427

Closed
enebo opened this issue Jan 5, 2015 · 1 comment
Closed

Ripper is still 2.0 grammar and has not been updated for 2.2 changes #2427

enebo opened this issue Jan 5, 2015 · 1 comment
Milestone
JRuby 9.0.0.0.rc2

Comments

@enebo
Copy link
Member

enebo commented Jan 5, 2015

Ripper is still 2.0 grammar and has not been updated for 2.2 changes
@enebo enebo added this to the JRuby 9.0.0.0 milestone Jan 5, 2015
@enebo
Copy link
Member Author

enebo commented Jun 26, 2015

I fixed this for rc1 actually but I will mark here so it shows up in some release notes.

@enebo enebo closed this as completed Jun 26, 2015
yujinakayama added a commit to rspec/rspec-core that referenced this issue Oct 30, 2015
@yujinakayama
Handle syntax error in Ripper
9aab631 
Ripper might fail to parse a Ruby source even if the current runtime
parsed it properly, because some versions of JRuby have different
implementation of runtime parser and Ripper parser.

jruby/jruby#2427

So we handle the syntax error in Ripper and fall back to the simple
single line extraction in that case.
@yujinakayama yujinakayama mentioned this issue Oct 30, 2015
Merged
yujinakayama added a commit to rspec/rspec-core that referenced this issue Oct 30, 2015
@yujinakayama
Handle syntax error in Ripper
d439a70 
Ripper might fail to parse a Ruby source even if the current runtime
parsed it properly, because some versions of JRuby have different
implementation of runtime parser and Ripper parser.

jruby/jruby#2427

So we handle the syntax error in Ripper and fall back to the simple
single line extraction in that case.
yujinakayama added a commit to rspec/rspec-core that referenced this issue Oct 30, 2015
@yujinakayama
Handle syntax error in Ripper
3ee6c88 
Ripper might fail to parse a Ruby source even if the current runtime
parsed it properly, because some versions of JRuby have different
implementation of runtime parser and Ripper parser.

jruby/jruby#2427

So we handle the syntax error in Ripper and fall back to the simple
single line extraction in that case.
yujinakayama added a commit to rspec/rspec-core that referenced this issue Oct 30, 2015
@yujinakayama
Handle syntax error in Ripper
f00ec60 
Ripper might fail to parse a Ruby source even if the current runtime
parsed it properly, because some versions of JRuby have different
implementation of runtime parser and Ripper parser.

jruby/jruby#2427

So we handle the syntax error in Ripper and fall back to the simple
single line extraction in that case.
myrridin pushed a commit to myrridin/rspec-core that referenced this issue Dec 11, 2015
@yujinakayama @thomashart
Handle syntax error in Ripper
d7ead23 
Ripper might fail to parse a Ruby source even if the current runtime
parsed it properly, because some versions of JRuby have different
implementation of runtime parser and Ripper parser.

jruby/jruby#2427

So we handle the syntax error in Ripper and fall back to the simple
single line extraction in that case.
MatheusRich pushed a commit to MatheusRich/rspec-core that referenced this issue Oct 30, 2020
@yujinakayama
Handle syntax error in Ripper
87d3d81 
Ripper might fail to parse a Ruby source even if the current runtime
parsed it properly, because some versions of JRuby have different
implementation of runtime parser and Ripper parser.

jruby/jruby#2427

So we handle the syntax error in Ripper and fall back to the simple
single line extraction in that case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.0.0.0.rc2
Development

No branches or pull requests
1 participant
@enebo