improved respond_to to automatically render an empty 204 response for…

… unknown formats
mojolicious · Aug 24, 2011 · 9b9125b · 9b9125b
1 parent ef899b6
commit 9b9125b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/Changes b/Changes
@@ -1,6 +1,8 @@
 This file documents the revision history for Perl extension Mojolicious.
 
 1.90    2011-08-24 00:00:00
+        - Improved respond_to to automatically render an empty 204 response
+          for unknown formats.
         - Improved render_exception and render_not_found to use the current
           format if available. (alnewkirk)
         - Improved documentation.

diff --git a/lib/Mojolicious/Controller.pm b/lib/Mojolicious/Controller.pm
@@ -479,13 +479,12 @@ sub respond_to {
 
   # Fallback
   unless ($target) {
-    return unless $target = $args->{any};
+    return $self->rendered(204) unless $target = $args->{any};
     delete $stash->{format};
   }
 
   # Dispatch
   ref $target eq 'CODE' ? $target->($self) : $self->render($target);
-  return 1;
 }
 
 sub send_message {
@@ -956,14 +955,15 @@ Usually refers to a L<Mojo::Message::Response> object.
 
 =head2 C<respond_to>
 
-  my $success = $c->respond_to(
+  $c->respond_to(
     json => sub {...},
     xml  => {text => 'hello!'},
     any  => sub {...}
   );
 
 Automatically select best possible representation for resource from C<Accept>
-request header, C<format> stash value or C<format> GET/POST parameter.
+request header, C<format> stash value or C<format> GET/POST parameter,
+defaults to rendering an empty C<204> response.
 Note that this method is EXPERIMENTAL and might change without warning!
 
   $c->respond_to(

diff --git a/lib/Mojolicious/Guides/Rendering.pod b/lib/Mojolicious/Guides/Rendering.pod
@@ -293,7 +293,7 @@ single C<render> call.
   );
 
 And if no viable representation could be found, the C<any> fallback will be
-used.
+used or an empty C<204> response rendered automatically.
 
 =head2 Helpers
 

diff --git a/t/mojolicious/restful_lite_app.t b/t/mojolicious/restful_lite_app.t
@@ -23,7 +23,7 @@ get sub {
     json => sub { $self->render_json({just => 'works'}) },
     html => sub { $self->render_data('<html><body>works') },
     xml  => sub { $self->render_data('<just>works</just>') }
-  ) or $self->rendered(204);
+  );
 };
 
 # POST